Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect documentation regarding minimum version of TLS used #1453

Open
asobti opened this issue Aug 15, 2024 · 1 comment
Open

Incorrect documentation regarding minimum version of TLS used #1453

asobti opened this issue Aug 15, 2024 · 1 comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity

Comments

@asobti
Copy link

asobti commented Aug 15, 2024

https://keda.sh/docs/2.15/operate/cluster/#http-tls-min-version states that

By default, KEDA uses TLS1.2 as a minimum TLS version given it is the lowest version without vulnerabilities

whereas, https://keda.sh/docs/2.15/reference/faq/#how-do-i-run-keda-with-tls-v1.3-only states that

By default, Keda listens on TLS v1.1 and TLSv1.2, with the default Golang ciphersuites.

As per the code, the former (minimum TLS v1.2) is correct
https://github.com/kedacore/keda/blob/09a4951478746ba0d95521b786439e58aeda179b/pkg/util/tls_config.go#L91-L110

Expected Behavior

Documentation should correctly state that a minimum version of TLSv1.2 is used

Actual Behavior

Documentation states that TLSv1.1 and v1.2 are used

@asobti asobti added the bug Something isn't working label Aug 15, 2024
Copy link

stale bot commented Oct 17, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale All issues that are marked as stale due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant