Release: v0.5.0

[tomkerkhove]

This issue template is used to track the rollout of a new KEDA HTTP add-on version.

For the full release process, we recommend reading this document.

Required items

• List items that are still open, but required for this release

Timeline

We aim to release this release in the week of June 19th.

Progress

• Add the new version to GitHub Bug report template
• Create KEDA release
• Prepare & ship Helm chart
• Publish on Artifact Hub (repo)
• Provide update in Slack
• Tweet about new release

[tomkerkhove]

https://github.com/kedacore/charts/releases/tag/keda-add-ons-http-v0.5.0

[jocelynthode]

Hey, the new chart is not available through https://kedacore.github.io/charts. I also don't see it on artifacthub. (Checked here: https://artifacthub.io/packages/helm/kedacore/keda-add-ons-http)

Did something fail during the helm chart ship?

[JorTurFer]

Did something fail during the helm chart ship?

Thanks for the heads-up! Yes, the deployment pipeline failed. I have re-executed the workflow and it has passed. You can use it now and you can see it with helm repo update. IDK how artifacthub works but if it's based on the repo feed, I guess that it will be updated soon

[jocelynthode]

@JorTurFer I noticed 2 issues while trying the upgrade in the helm chart which breaks deployment, which I've reported there:

• Unknown flag --metrics-port on keda-add-ons-http operator with v0.5.0 Chart charts#472
• ClusterRole for keda-add-ons-http does not allow for HTTPScaledObject get charts#473

I also noticed that the ConfigMap for the routing table is still there even though I think we don't need it anymore.

After manually fixing those I was still getting errors and had to stop there and rollback. I'll try to investigate in the following days and see if I can provide a better bug report or if it's something on my end.

[JorTurFer]

Thanks for reporting the issues. I'll check them later on and hopefully the fix will be today or tomorrow

[JorTurFer]

This PR should fix both issues, thanks for reporting them: kedacore/charts#474
I have deployed that chart and executed the e2e tests suite and it has passed, so I think this is the good try 😄

[jocelynthode]

Thanks for the PR. I've also noted both these issues directly on the add-on related to the 0.5.0:

• ScaledObject labels increase character size  #717
• external-scaler spams log due to missing HTTPSO for dummy keda-add-ons-http-interceptor #718

The first one might be breaking for some users I know I got caught by it trying to deploy the new version on our stage cluster.

[JorTurFer]

Thanks for reporting them too ❤️
Are you willing to contribute with any of them by chance? don't worry if no, we will try to fix them in any case

[jocelynthode]

I'll have to see if I can free some time at work to take on an issue next week. I could try and tackle the label one. However I'll need to brush up on the routing table as I have not looked at all into the new implementation code.

…

-------- Message d'origine -------- Le 21 juin 2023, 23:26, Jorge Turrado Ferrero a écrit :

Thanks for reporting them too ❤️ Are you willing to contribute with any of them by chance? don't worry if no, we will try to fix them in any case — Reply to this email directly, [view it on GitHub](#715 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AA6ISUBVQ5JPTO5AKB4L2JTXMNRG7ANCNFSM6AAAAAAZM4DELM). You are receiving this because you commented.Message ID: ***@***.***>

[t0rr3sp3dr0]

@jocelynthode, the issues should be fixed and the following PRs get merged:

• HTTP Add-On: new interceptor scaling configuration charts#487
• reimplement custom interceptor metrics #720
• Remove ScaledObject Custom Labels #721

[t0rr3sp3dr0]

@JorTurFer @tomkerkhove, I think we should release a new version as soon as kedacore/charts#487 and #720 get merged. The interceptor scaling is completely broken on v0.5.0.

[jocelynthode]

Thanks for the very quick fixes! As soon as a new version with all 3 fixes is released I'll try to upgrade and test it again on real workloads!

…

-------- Message d'origine -------- Le 24 juin 2023, 02:42, Pedro Tôrres a écrit :

***@***.***(https://github.com/jocelynthode), the issues should be fixed and the following PRs get merged: - [kedacore/charts#487](kedacore/charts#487) - [#720](#720) - [#721](#721) — Reply to this email directly, [view it on GitHub](#715 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/AA6ISUHP5ZVXGOB5566M62DXMYZVVANCNFSM6AAAAAAZM4DELM). You are receiving this because you were mentioned.Message ID: ***@***.***>

[tomkerkhove]

@JorTurFer @tomkerkhove, I think we should release a new version as soon as kedacore/charts#487 and #720 get merged. The interceptor scaling is completely broken on v0.5.0.

Can you please check why our testing did not fail?

[JorTurFer]

Can you please check why our testing did not fail?

It's because the interceptor scaling itself isn't tested during e2e tests

[t0rr3sp3dr0]

And the manifests on this repository did not indicate we supported this. This was something that was only configured on the Helm Chart. So when I reimplemented the routing table, this feature was erroneously removed.

[tomkerkhove]

Can you please check why our testing did not fail?

It's because the interceptor scaling itself isn't tested during e2e tests

Which begs the question - Why? Can we add this?

[JorTurFer]

This process is similar as in core, we need to manually port the changes in manifests from code repo to helm repo and it could have human fails

[jocelynthode]

Hey, are we still missing a fix or could we release a 0.5.x hotfix version as the current version (0.5.0) does not have the fixes and I'd prefer not having to use a specific tag from a commit.

[tomkerkhove]

We're waiting for #727 & #700

[jocelynthode]

Hey @tomkerkhove: I see that #700 is still open. Is there something I could do to help move it forward so that we can cut a hotfix? I'd really like to upgrade to 0.5 as there are a lot of cool things in this release 😃

[JorTurFer]

Hi @jocelynthode
I guess that until the end of August we won't cut a release as we are during summer break: kedacore/keda#4773

In any case, I think that we can close this issue and aim to a version 0.5.1 or 0.6.0.
WDYT @tomkerkhove @t0rr3sp3dr0 ?

[tomkerkhove]

I'm fine with 0.5.1 or 0.6.0.

Closing