Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle signals in the interceptor & drain requests #370

Closed
arschles opened this issue Jan 19, 2022 · 1 comment
Closed

Handle signals in the interceptor & drain requests #370

arschles opened this issue Jan 19, 2022 · 1 comment
Labels
enhancement New feature or request feature

Comments

@arschles
Copy link
Collaborator

arschles commented Jan 19, 2022

The interceptor should not just shut down when it receives a signal. Instead, it should ensure that all requests are complete and then shut down.

Use-Case

When KEDA scales the interceptor pool down, or a user manually shuts down an interceptor pod, the interceptor should not sever the connection. Instead, it should complete the pending requests (some of which may be hanging for a long time, while they wait for replicas to be available) and then shut down.

Specification

When interceptor receives a signal:

  1. It should stop accepting new incoming requests (and connections)
  2. It should continue processing existing pending requests
  3. Only after (2) is done, it should shut down

cc/ @asw101 since we discussed this earlier offline.

@arschles arschles added enhancement New feature or request feature labels Jan 19, 2022
@arschles arschles modified the milestones: v0.3.0, v0.4.0 Jan 21, 2022
@tomkerkhove tomkerkhove removed this from the v0.4.0 milestone May 11, 2022
@JorTurFer
Copy link
Member

This has already done and released by #732

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request feature
Projects
Status: Done
Development

No branches or pull requests

3 participants