Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate spec.scaleTargetRef.deployment #1061

Closed
zroubalik opened this issue Jun 7, 2024 · 0 comments · Fixed by #1060
Closed

Deprecate spec.scaleTargetRef.deployment #1061

zroubalik opened this issue Jun 7, 2024 · 0 comments · Fixed by #1060

Comments

@zroubalik
Copy link
Member

Proposal

Let's deprecate this field to be able to support more types, not just Deployments. The same way it is done for KEDA.

kind: HTTPScaledObject
...
spec:
...
    scaleTargetRef:
        deployment: xkcd
        service: xkcd
        port: 8080

->

kind: HTTPScaledObject
...
spec:
...
    scaleTargetRef:
        name: xkcd
        kind: Deployment
        apiVersion: apps/v1
        service: xkcd
        port: 8080

Use-Case

No response

Is this a feature you are interested in implementing yourself?

Yes

Anything else?

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant