New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not using namespaces for `set` seems to be wrong #810

Open

blaggacao opened this issue Jul 18, 2024 · 0 comments

blaggacao commented Jul 18, 2024 •

edited

Loading

pypika/pypika/queries.py

Line 1557 in 53a77eb

    
           field=field.get_sql(**dict(kwargs, with_namespace=False)), value=value.get_sql(**kwargs)

This is perfecly legal SQL:

    UPDATE `tabList of Contacts Member` locm
    JOIN `tabContact` c ON c.name = locm.contact
    SET locm.unsubscribed = 1  --- note the namespaced column here, without it, this query is ambiguous
    WHERE (locm.unsubscribed IS NULL OR locm.unsubscribed = 0)
      AND c.unsubscribed = 1

If this name spacing was disabled for a particular reason, maybe a code comment would help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment