Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The IR tests are currently disabled #396

Open
katef opened this issue Mar 31, 2023 · 0 comments
Open

The IR tests are currently disabled #396

katef opened this issue Mar 31, 2023 · 0 comments
Labels

Comments

@katef
Copy link
Owner

katef commented Mar 31, 2023

From fcad35e:

Disable the fragile IR tests.

These are fragile due to testing the graph structure when rendered to json literally. The problem here is the state numbering and order matter, and that depends on the compiler's code generation, malloc, current wind direction, etc.

What we should be doing here is comparion of the graph's structure, but I don't know how to do that.

We're effectively covering the same situations through end-to-end tests for the generated code, so I'm just going to disable these until I come up with a better way to deal with the IR structure.

@katef katef added the bug label Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant