From 3769f7743c673e623fd6f5b3519d3d250cfce471 Mon Sep 17 00:00:00 2001
From: Kate F <kate@elide.org>
Date: Sat, 24 Aug 2024 15:05:32 +0100
Subject: [PATCH] Off by one.

Previously this gave:
```
; ./build/bin/re -r literal -G 3 abc
; ./build/bin/re -r literal -G 4 abc
abc
;
```
and now -G 3 does construct "abc" (not including the newline, which is a property of the printing, not of the constructed string):
```
; ./build/bin/re -r literal -G 3 abc
abc
; ./build/bin/re -r literal -G 4 abc
abc
;
```

and:
```
; ./build/bin/re -r native -G 3 '^x+$'
x
xx
xxx
```

Spotted by @pierreganty (#478), thank you
---
 src/libfsm/gen.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/src/libfsm/gen.c b/src/libfsm/gen.c
index 790579dc8..aaf095674 100644
--- a/src/libfsm/gen.c
+++ b/src/libfsm/gen.c
@@ -8,6 +8,7 @@
 #include <stddef.h>
 #include <stdbool.h>
 #include <string.h>
+#include <errno.h>
 
 #include <fsm/fsm.h>
 #include <fsm/pred.h>
@@ -139,6 +140,11 @@ int
 fsm_generate_matches(struct fsm *fsm, size_t max_length,
     fsm_generate_matches_cb *cb, void *opaque)
 {
+	if (max_length == 0) {
+		errno = EINVAL;
+		return 0;
+	}
+
 	INIT_TIMERS();
 	TIME(&pre);
 	int res = gen_init_outer(fsm, max_length, cb, opaque, false, 0);
@@ -562,8 +568,8 @@ sfs_step_edges(struct gen_ctx *ctx, struct gen_stack_frame *sf)
 		sf->u.step_edges.initialized = true;
 	}
 
-	if (ctx->buf_used + ctx->sed[sf->s_id] >= ctx->max_length) {
-		LOG(2, "PRUNING due to max length: used:%zu + sed[%d]:%u >= max_length:%zu\n",
+	if (ctx->buf_used + ctx->sed[sf->s_id] > ctx->max_length) {
+		LOG(2, "PRUNING due to max length: used:%zu + sed[%d]:%u > max_length:%zu\n",
 		    ctx->buf_used, sf->s_id, ctx->sed[sf->s_id], ctx->max_length);
 		sf->t = GEN_SFS_LEAVING_STATE;
 		return true;