Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in security logic of openIdConnect #12

Open
clapton2008 opened this issue Jun 22, 2021 · 2 comments
Open

error in security logic of openIdConnect #12

clapton2008 opened this issue Jun 22, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@clapton2008
Copy link

There is no way to correctly get Claims when using the OpenID Connect type. The Open Api specification allows you to use Claims, and I attach the link. https://swagger.io/docs/specification/authentication/openid-connect-discovery/ and in the code, due to the fact that cut off Scopes when there are no flows, there is no way to get them. https://github.com/karlvr/openapi-generator-plus/blob/master/packages/core/src/process/security.ts#L89 the logic of processing and there is below, but it is possible when something went wrong) scopes: scopeObjects was null when use OpenID Connect

@karlvr
Copy link
Owner

karlvr commented Jun 24, 2021

Hi! Thank you very much for this. I haven't used OpenApiConnect with OpenAPI so I've probably just overlooked it. Do you want to suggest a PR to correct this? I presume we'll need to add some more data into the types to store the claims?

@karlvr
Copy link
Owner

karlvr commented Sep 8, 2021

@clapton2008 if you have a moment, would you be able to paste in an example spec so I can make sure that all of the required info is exposed?

@karlvr karlvr added the bug Something isn't working label Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants