Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date repeat #15

Closed
rougier opened this issue Jan 4, 2020 · 5 comments · Fixed by #60
Closed

Date repeat #15

rougier opened this issue Jan 4, 2020 · 5 comments · Fixed by #60

Comments

@rougier
Copy link

rougier commented Jan 4, 2020

I'm trying to retrieve the repeat part of a scheduled date but it is not clear if it saved during parsing. It seems the date regex take care of that (cookie part from what I've understood) but then I get lost. On simple example I would like to use:

import orgparse
node = orgparse.loads('''
* Pay the rent
  SCHEDULED: <2020-01-01 Wed +1m>
''').children[0]
time = node.scheduled
# repeat = node.???
@karlicoss
Copy link
Owner

Hi, thanks for reporting and sorry for a late response, somehow missed the issue notification!

Yep, you're right, it seems to be parsed here, but never actually extracted from the parsing result.

The fix would probably be somewhere here. Potentially OrgDateRepeatedTask might also be involved, but I need to figure out whether it's what it was meant for (I'm not the original author). I'll try to look deeper when I have a bit more time.

@karlicoss
Copy link
Owner

Also related: #14

@karlicoss
Copy link
Owner

Should be fixed now! Thanks @j3soon :)

@j3soon
Copy link
Contributor

j3soon commented Nov 12, 2022

Seems like this issue isn't fixed in the PyPI package (v0.3.1) yet.

@karlicoss can you build and upload the latest version of orgparse to PyPI? Thanks!

@j3soon
Copy link
Contributor

j3soon commented Nov 14, 2022

I just found that #50 didn't fix this issue, since it only parses timestamp cookies for timestamps without SCHEDULED or DEADLINE.

I'll submit another PR to fix this completely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants