-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtitle without a DEFAULT=YES, AUTOSELECT=YES #1503
Comments
Set up nginx-proxy in front of kaltura with sub_filter/subs_filter/js_body_filter. |
@maximk-1 Yeah, this has crossed our mind too, but we thought if there was a straight way to do this instead of hacking our way into it. |
Also we do not want to disable autoselect in all playlists, some playlists may be needed to have a default autoselected subtitle. |
Hi, can you explain what do you mean by 'empty subtitle track'? because my interpretation of 'empty' is a subtitle track without any cues, and in that case it sounds very weird. It is possible, for example, that the first subtitle cue arrives only after a minute (e.g. a video that starts by playing some music) - the client has no way of knowing whether the subtitle track is empty or not, before it downloads all the subtitle segments. Also, even when the input file is empty, the module serves valid WebVTT segments to the client - that contain only the WEBVTT header. |
Sorry, I should've been more informative, by empty I mean something like this:
Adding a long duration subtitle without any real subtitle fixed the issue for us, something like this:
https://www.w3.org/TR/webvtt1/#file-structure
Please correct me, but the json which I've just posted provides this in master.m3u8:
and
So there is no WebVTT file, whether it has valid WebVTT headers or not. |
You are using |
To not show subtitle by default, how should we do that? |
If module does not always picks up the first subtitle and appends |
Got it, makes sense. I agree the correct solution is to make the default/autoselect configurable, as you initially suggested. |
@erankor We do not have exact duration of all sequences currently, so we cannot add duration right now. I would appreciate if you could point me to where to look to make it configurable, so I can come up with a PR improving this. |
Hi, had some free time... opened #1506 for this, please give it a try (I didn't have time to test it myself, but seems pretty simple) |
Thanks, merged |
Thank you! |
We use androidx/media (former exoplayer) to play m3u8s created by nginx-vod-module, and it crashes when there is an empty subtitle track by default.
So I was wondering what is the standard for this and if there MUST be a
AUTOSELECT=YES
in every m3u8, and I've reached this:https://datatracker.ietf.org/doc/html/rfc8216:
which from what I understand both autoselect and default are optional, and it has not mentioned that there SHOULD be a
DEFAULT=YES, AUTOSELECT=YES
inmaster.m3u8
.So right now we cannot include subtitles in m3u8 with an empty default, I was wondering how can we have subtitles in m3u8 which none of them are default, and it can be manipulated in json, if having a default subtitle is desirable.
Something like this:
and
P.S.
I totally understand if you say this is the way currently is and you don't have time / energy to change this, but I would appreciate if you could point me to the correct directions of how to change this, therefore I can whip up a PR for this, so everyone benefits from this new feature, thank you!
The text was updated successfully, but these errors were encountered: