Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdParameters from VAST not provided to VPAID ads in creativeData #1601

Open
j-f-g opened this issue Mar 9, 2015 · 2 comments
Open

AdParameters from VAST not provided to VPAID ads in creativeData #1601

j-f-g opened this issue Mar 9, 2015 · 2 comments

Comments

@j-f-g
Copy link

j-f-g commented Mar 9, 2015

The creativeData object that's passed into the initAd method of VPAID ads seems to be empty. According to the HTML5 spec (Section 8.1.1, http://www.iab.net/media/file/VPAID_2.0_Final_04-10-2012.pdf), the creativeData object should provide the text from the AdParameters node of the VAST the VPAID ad was loaded from.

For example, if the VAST looks like:

...
<Creative ...>
  <Linear>
    <AdParameters><![CDATA[My Data]]></AdParameters>
...

The creativeData object passed into initAd should look like { 'AdParameters': 'My Data' }.

@j-f-g
Copy link
Author

j-f-g commented Mar 19, 2015

I think this might just be a matter of changing line 1336 of mw.KAdPlayer.js as follows (although I'm not 100% sure of the format of adConf.adParameters):

var creativeData = { 'AdParameters': adConf.adParameters };

@j-f-g
Copy link
Author

j-f-g commented Jun 12, 2015

Can anyone else confirm that this is indeed an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant