Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more lsp features #19

Open
aszenz opened this issue Aug 27, 2023 · 3 comments
Open

Support more lsp features #19

aszenz opened this issue Aug 27, 2023 · 3 comments

Comments

@aszenz
Copy link

aszenz commented Aug 27, 2023

Thanks for making this and improving the lives of twig developers.

Before using the vscode plugin I used https://marketplace.visualstudio.com/items?itemName=mblode.twig-language-2.

I'm missing some feature from it though:

  1. Twig snippets like these
do                {% do ... %}
extends           {% extends 'template' %}
from              {% from 'template' import 'macro' %}
  1. Support formatting maybe integrate with third party plugin like prettydiff
  2. Some form of go-to-definition (maybe for blocks and macros initially)
@kaermorchen
Copy link
Owner

kaermorchen commented Aug 27, 2023

Did you try to use the both extensions together? They shouldn't conflict.

@aszenz
Copy link
Author

aszenz commented Aug 27, 2023

Did you try to use the both extensions together? They shouldn't conflict.

Yes i could use the snippets from the library, and use this library for syntax highlighting

@moetelo
Copy link
Contributor

moetelo commented Sep 22, 2023

@aszenz

Some form of go-to definition

Implemented that here for include('template.html.twig') and other template inclusion statements/functions.
#27

Please tell me if something is missing for this feature. PR review is welcomed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants