-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MorphMan doesn't work with PyQt5 anymore #286
Comments
About Anki Debug Info
|
It was not intentional. I'll update it to add back Qt5 support. Out of curiosity, why are you using the Qt5 release of Anki? I thought the Qt6 version had backward compatibility with Qt5 for addons. |
Thank you! To answer your question: I was not aware of that backwards compatibility. I have not read into this update yet and was afraid that moving to Qt6 would break everything but now I know. Thank you a second time 🙂 |
https://docs.ankiweb.net/platform/windows/installing.html?highlight=qt6#qt5-vs-qt6
I have experienced myself that some add-ons don't work anymore when I use Qt6 |
@landonepps, I am also having this issue. Currently using: Anki 2.1.54 (b6a7760c) Python 3.9.7 Qt 5.15.2 PyQt 5.15.5 Does this mean I should upgrade to the Qt6 version for now? I just downloaded the addon as-is from the anki add-ons page since it didn't seem like there was a release on the github page. |
If anyone comes to see this, yes, you need to upgrade to Qt6. I also upgraded to Anki 2.1.58 when doing so but it's working now. |
Shouldn't we be using "aqt.qt" instead of directly using "PyQt6" or "PyQt6"? |
We could probably support both qt5 and qt6 at the same time by doing that way. What do you think? |
I did a POC to see if this would work. Seems fine. If you wanna take a look. |
Using FYI, looking at the generated python files in rameauv@03e3318, it seems like your line endings are messed up. |
I'll refactor this and make a pr 👌 |
Should I start from the master branch? |
I merged your changes to What addons are people using that don't support PyQt6? |
Yes exact. As long as anki qt6 support qt5 addons with the compatibility mode enabled by default it should work. |
If someone who uses the Qt5 version of Anki could test the lastest AnkiWeb version of MorphMan, I'd really appreciate it. I believe it should now be backwards compatible with Qt5. Please let us know here if you're still experiencing issues. |
I got the message below after updating MorphMan:
I read that support for PyQt6 was just added, but I'm confused if PyQt5 was dropped by mistake or not.
The text was updated successfully, but these errors were encountered: