Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing to fmt for official example #9

Closed
kachick opened this issue Aug 15, 2024 · 2 comments · Fixed by #22
Closed

Failing to fmt for official example #9

kachick opened this issue Aug 15, 2024 · 2 comments · Fixed by #22
Labels
bug Something isn't working

Comments

@kachick
Copy link
Owner

kachick commented Aug 15, 2024 •
edited
Loading

#8

Error formatting /home/kachick/repos/github.com/kachick/dprint-plugin-kdl/example/official.expected.kdl. Message: Formatting succeeded initially, but failed when ensuring a stable format. This is most likely a bug in the plugin where the text it produces is not syntatically correct. Please report this as a bug to the plugin that formatted this file.

Expected valid node terminator.
Had 1 error formatting.
@kachick kachick added the bug Something isn't working label Aug 15, 2024
This was referenced Aug 15, 2024
Merged
Closed
@kachick kachick added this to 🛸 Aug 26, 2024
@github-project-automation github-project-automation bot moved this to 🙋‍♂ in 🛸 Aug 26, 2024
kachick added a commit that referenced this issue Aug 27, 2024
@kachick
Extract and clarify broken pattern from example
af516b3 
Closes GH-9
@kachick kachick mentioned this issue Aug 27, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🙋‍♂ to 🎉 in 🛸 Aug 27, 2024
@kachick kachick mentioned this issue Oct 7, 2024
Closed
@kachick
Copy link
Owner Author

kachick commented Dec 23, 2024

Might be fixed in kdl-org/kdl-rs#77

kachick added a commit that referenced this issue Dec 23, 2024
@kachick
Update known issues
a4b6447 
ref: #9
kachick added a commit that referenced this issue Dec 23, 2024
@dependabot @kachick
Bump kdl from 4.7.1 to 6.1.0 (#83)
e0ac047 
* Bump kdl from 4.7.1 to 6.1.0

Bumps [kdl](https://github.com/kdl-org/kdl-rs) from 4.7.1 to 6.1.0.
- [Release notes](https://github.com/kdl-org/kdl-rs/releases)
- [Changelog](https://github.com/kdl-org/kdl-rs/blob/main/CHANGELOG.md)
- [Commits](kdl-org/kdl-rs@v4.7.1...v6.1.0)

---
updated-dependencies:
- dependency-name: kdl
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* Update signatures

* Update version matrix

* Update description for versions

* Update example and the code

* Update known issues. See #9

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Kenichi Kamiya <[email protected]>
@kachick
Copy link
Owner Author

kachick commented Dec 23, 2024

After #83, it is reversible now. So I removed the known issue files even if layout is not ideal state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
🛸
Archived in project
Milestone
No milestone
1 participant
@kachick