fix: import failure on Python >=3.10 #92
Open
+3
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lucasew <[email protected]>
|
Duplicate of #87, which has better compatibility.
This one should work for newer Python versions, while not breaking compatibility with older ones: try:
from collections.abc import Iterable
except ImportError: # py < 3.3
from collections import Iterable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My worry is that this breaks backward compatibility because the
typingmodule was added on Python 3.5 [1], so it would only work on Python 3.5 and above.We realized this because the nixpkgs CI [2] fails to package this library to be used by other dependents. It's not that a huge problem because basically all of the stuff depends on the version based on Python 3.9, that works fine [3].
[1] https://docs.python.org/3/library/typing.html
[2] https://hydra.nixos.org/job/nixpkgs/trunk/python310Packages.fn.x86_64-linux
[3] https://hydra.nixos.org/job/nixpkgs/trunk/python39Packages.fn.x86_64-linux
Closes #91 #86