Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ToggleComment Issues #73

Open
Enteleform opened this issue Dec 22, 2017 · 2 comments
Open

ToggleComment Issues #73

Enteleform opened this issue Dec 22, 2017 · 2 comments

Comments

@Enteleform
Copy link

Just ran into 2 issues with the ToggleComment command.

The first one is more of an unexpected difference in implementation.  Having worked with various editors (Sublime Text, Atom, Light Table, misc JetBrains IDEs, etc.), the 'move down a line after commenting' action is something I've never come across until now.  Any way this could be implemented as an option? 

The second one pertains to text in the surrounding regions of the selection.  For some reason, it becomes indented after the selected region is uncommented:

hotcommands_comment

@justcla
Copy link
Owner

justcla commented Dec 22, 2017

The 'move down a line after commenting' is a feature taken from the JetBrains implementation in IntelliJ and R#. It only moves down a line if there is no selection. But, all the same, for users who want a different behavior, an option would be handy.

I've never created an Options page before. I guess this seems like a good enough reason to try. I'll see what I can do.

If anyone else thinks they can do it, please go ahead and submit a PR! Thanks.

@justcla
Copy link
Owner

justcla commented Dec 22, 2017

As for the strange indenting behavior - that's odd. It shouldn't be touching anything outside the affected region. I'll see if I can find out what's going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants