Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Formatting checks limited to ./dev #238

Open
shivaraj-bh opened this issue Jun 16, 2024 · 0 comments
Open

CI: Formatting checks limited to ./dev #238

shivaraj-bh opened this issue Jun 16, 2024 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@shivaraj-bh
Copy link
Member

shivaraj-bh commented Jun 16, 2024 •
edited by srid
Loading

Cause: #121 disabled treefmt.flakeCheck in favour of pre-commit’s flake check

Effect (bug): Now, the project root for the flake check for formatting is limited to only the ./dev. That is, it no longer checks that files outside of ./dev are auto-formatted or not. But it should.
@shivaraj-bh shivaraj-bh added good first issue Good for newcomers bug Something isn't working labels Jun 16, 2024
@shivaraj-bh shivaraj-bh changed the title Formatting checks limited to ./dev CI: Formatting checks limited to ./dev Jun 16, 2024
@shivaraj-bh shivaraj-bh mentioned this issue Jun 16, 2024
Merged
srid added a commit that referenced this issue Jun 21, 2024
@srid
chore(dev): Re-enable treefmt-nix flake check
7b9acb6 
As a workaround for #238 until we have a proper fix.
@srid srid mentioned this issue Jun 21, 2024
Merged
srid added a commit that referenced this issue Jun 21, 2024
@srid
chore(dev): Re-enable treefmt-nix flake check
c371cd5 
As a workaround for #238 until we have a proper fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shivaraj-bh