Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update README.md with JupyterLite site instructions #25

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

Vipul-Cariappa
Copy link
Contributor

@DerThorsten DerThorsten added the documentation Improvements or additions to documentation label Jan 9, 2024
@martinRenou
Copy link
Member

martinRenou commented Jan 9, 2024

Thanks! @Vipul-Cariappa

It seems you're not getting credits for your changes in Github UI. You are creating your commits with an email address ending with @.com (see https://github.com/jupyterlite/xeus/commit/078cc6f641bb241bc9953fef7b5e5b904af4603a.patch).

It seems it's not a valid email address? This may be fine if you add this address to your Github account https://github.com/settings/emails (no need to verify your email address for Github to consider the commits coming from this address to be yours). Though you may want to fix this in your git config and provide a real address.

@Vipul-Cariappa
Copy link
Contributor Author

@martinRenou, Thanks for pointing out that my email configured is wrong. I have fixed it using git config --global user.email "[email protected]".
Any commits in the future should work fine.

@Vipul-Cariappa
Copy link
Contributor Author

Hope the failing test is not my doing?

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment, otherwise looks good thanks!

The CI failure seems to be a flaky test, not yours.

README.md Outdated Show resolved Hide resolved
Co-authored-by: martinRenou <[email protected]>
@martinRenou martinRenou merged commit 63fb463 into jupyterlite:main Jan 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants