Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to benchmark lumino branches/forks? #83

Open
krassowski opened this issue Dec 19, 2021 · 2 comments
Open

How to benchmark lumino branches/forks? #83

krassowski opened this issue Dec 19, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@krassowski
Copy link
Member

krassowski commented Dec 19, 2021

Problem

Running benchmarks against custom branches of JupyterLab is a pleasant experience, but benchmarking against custom lumino forks seems tricky. Can we benchmark JupyterLab against a lumino fork/branch?

Proposed Solution

We could add another parameter to the GitHub Action, which would result in using lumino from given fork/branch.

I initially thought about a local NPM registry overwriting the published lumino versions, but probably we should just make use of: https://jupyterlab.readthedocs.io/en/stable/developer/contributing.html#linking-unlinking-packages-to-jupyterlab

Additional Context

@fcollonval I wonder what was your workflow for jupyterlab/lumino#231 was your benchmarking automated or fully manual?

@krassowski krassowski added the enhancement New feature or request label Dec 19, 2021
@welcome
Copy link

welcome bot commented Dec 19, 2021

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@fcollonval
Copy link
Member

@fcollonval I wonder what was your workflow for jupyterlab/lumino#231 was your benchmarking automated or fully manual?

At the time I ran tests locally. I did the benchmark CI work afterwards. But indeed, we could duplicate the existing workflow to address this case. It will also require defining test cases as the current ones are probably not highly impacted by lumino.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants