New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The "Open this repository on GitLab button" is always trying to open the file in the "master" branch #3

Open

beenje opened this issue Aug 2, 2023 · 0 comments

Labels

bug

Collaborator

beenje commented Aug 2, 2023

Description

The "master" branch is hard-coded when using the "Open this repository on GitLab" button:

jupyterlab-gitlab/src/browser.ts

Lines 53 to 60 in ce6f375

    
           if (resource.repository) { 
        
             url = URLExt.join( 
        
               url, 
        
               resource.repository, 
        
               'tree', 
        
               'master', 
        
               resource.path 
        
             );

The button should use the repository default branch instead.

Note that when browsing a repository, the default branch is now retrieved via the API (see dd985a3) but this isn't used for the toolbar button yet.

The text was updated successfully, but these errors were encountered:

beenje added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment