Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the storage of comments to have identity be dependent on the user id #85

Open
srirag-vuppala opened this issue Jul 27, 2021 · 3 comments
Open

Refactor the storage of comments to have identity be dependent on the user id #85

srirag-vuppala opened this issue Jul 27, 2021 · 3 comments
Assignees
@srirag-vuppala
Labels
enhancement New feature or request

Comments

@srirag-vuppala
Copy link
Collaborator

Present implementation stores the identity of the user thus making changes in identity tougher to be propagated.
Ideally we would have a function that hooks onto a central map that associates a user id to the identity of the user and thus having a centralized model for identity.
@srirag-vuppala srirag-vuppala self-assigned this Jul 28, 2021
@srirag-vuppala srirag-vuppala linked a pull request Jul 28, 2021 that will close this issue
Updating identity on change #86
Merged
@srirag-vuppala srirag-vuppala mentioned this issue Jul 28, 2021
Merged
@srirag-vuppala srirag-vuppala removed a link to a pull request Jul 28, 2021
Updating identity on change #86
Merged
@srirag-vuppala srirag-vuppala added the help wanted Extra attention is needed label Jul 28, 2021
@jess-x
Copy link

jess-x commented Jul 30, 2021

Hi @srirag-vuppala, I want to say I have some idea about this. Would love to connect, and see if i can help :)

@srirag-vuppala
Copy link
Collaborator Author

Definitely! I'll send over an email and we can go from there 👍🏾

Hi @srirag-vuppala, I want to say I have some idea about this. Would love to connect, and see if i can help :)

@jess-x
Copy link

jess-x commented Jul 30, 2021

Definitely! I'll send over an email and we can go from there 👍🏾

Thx @srirag-vuppala for the email. I am on also on gitter https://gitter.im/jess-x, and might be more responsive there

@jess-x jess-x mentioned this issue Jul 30, 2021
Open
@srirag-vuppala srirag-vuppala added enhancement New feature or request and removed help wanted Extra attention is needed labels Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@srirag-vuppala srirag-vuppala

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jess-x @srirag-vuppala