Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support type annotations #204

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Support type annotations #204

merged 7 commits into from
Jan 2, 2025

Conversation

davidbrochart
Copy link
Collaborator

Closes #203.

@davidbrochart davidbrochart marked this pull request as draft December 11, 2024 15:00
@davidbrochart davidbrochart force-pushed the typing branch 5 times, most recently from 227b925 to e2a944c Compare December 12, 2024 08:51
@davidbrochart
Copy link
Collaborator Author

I think it's not enough to support generic types. For instance, a Map should support something like a TypedDict.

@davidbrochart davidbrochart force-pushed the typing branch 4 times, most recently from 6b86634 to d158ede Compare January 2, 2025 15:32
@davidbrochart davidbrochart marked this pull request as ready for review January 2, 2025 15:41
@davidbrochart davidbrochart merged commit 6a5567e into jupyter-server:main Jan 2, 2025
12 checks passed
@davidbrochart davidbrochart deleted the typing branch January 2, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support type annotations
1 participant
@davidbrochart