Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong usage of i18n #1479

Open
Carreau opened this issue Dec 17, 2024 · 0 comments
Open

Wrong usage of i18n #1479

Carreau opened this issue Dec 17, 2024 · 0 comments
Labels

Comments

@Carreau
Copy link
Contributor

Carreau commented Dec 17, 2024

jupyter_server/serverapp.py
2861:        info += _i18n(f"Jupyter Server {ServerApp.version} is running at:\n{self.display_url}")

jupyter_server/auth/identity.py
654:                self.log.info(_i18n(f"Wrote hashed password to {config_file}"))

At least those two usage are wrong; the f-string will be formatted before the call to internationalisation. It should be _i18n(...).format().

In general we could likely grep the codebase for i18n\([^'\")], and any non-literal string in i18n will be wrong.

@Carreau Carreau added the bug label Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant