Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a trailing slash to the deployment context of the GitHub Pages deployment Action #1667

Open
anjackson opened this issue Nov 21, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@anjackson
Copy link

Description

I'm deploying a site to GitHub Pages as per the instructions. Once deployed under a context path (i.e. not at the server root), relative links that worked in local development (like this one) no longer work. This seems to be because the BASE_URL is not configured correctly.

Proposed solution

Currently the provided settings look like this:

/${{ github.event.repository.name }}

But for relative links to work, it needs a trailing slash:

/${{ github.event.repository.name }}/

Additional notes

❯ myst -v
v1.3.18
@anjackson anjackson added the bug Something isn't working label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant