Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image path handling should resolve paths as URIs #1588

Open
agoose77 opened this issue Oct 17, 2024 · 0 comments
Open

Image path handling should resolve paths as URIs #1588

agoose77 opened this issue Oct 17, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@agoose77
Copy link
Contributor

agoose77 commented Oct 17, 2024

In attempting to debug #1587, I created a simple demo:

# Main

![](2024-09-05 17-39-05.mp4)

I then realised that the link reference contains a space, which is prohibited by the CommonMark spec (and is generally link-like behaviour). So, I updated the example to use autolink syntax which is a suggested mechanism of escaping whitespace:

# Main

![](<2024-09-05 17-39-05.mp4>)

I could also have written

![](2024-09-05%2017-39-05.mp4)

but the bracket syntax is more readable (to me).

This failed to load the image. It looks like we're just appending the urlSource to the path for local files rather than URL decoding the name.

@agoose77 agoose77 added the bug Something isn't working label Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant