You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since #444 this may not longer be the case as we not also have nav components in the sidebar.
For any changes consider not drilling hide_toc down into components and how they might map to mobileOnly & hideToc props.
Desired behaviour hide_toc is that the table of contents should never be shown.
todo
let's map out the user stories for end states
The text was updated successfully, but these errors were encountered:
Adding to this (Steve and I were in a Zoom meeting), right now it feels like we have a lot of confusing state options internally. We identified that there are really three behaviours that we want to capture:
Users have a ToC, and maybe have a nav. They want the primary sidebar to be visible at all times (either as a drawer, or fixed on the page). They want the burger menu to appear only when the sidebar behaves as a drawer.
Users don't have a ToC, and have a nav. They want to hide_toc so that the primary sidebar is not visible unless the primary nav needs to be folded into the sidebar. They want the burger menu to appear when the sidebar is visible and acting as a drawer.
Users don't have a ToC or a nav. They never want to see the primary sidebar or burger menu.
To me, that means hide_toc is the only configurable theme option. The rest is just reactive semantics.
Steve reminded me that we need to think about how to achieve this with SSR and hydration.
Since #444 this may not longer be the case as we not also have nav components in the sidebar.
For any changes consider not drilling
hide_toc
down into components and how they might map tomobileOnly
&hideToc
props.Desired behaviour
hide_toc
is that the table of contents should never be shown.todo
The text was updated successfully, but these errors were encountered: