Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing results regarding churn (start_ago default not clear) #80

Open
etagwerker opened this issue May 4, 2020 · 0 comments
Open

Comments

@etagwerker
Copy link
Contributor

etagwerker commented May 4, 2020

Hi there,

I may have ran into an edge case. I recently started maintaining a project that had been inactive for a while (metric_fu). Then I tried to run attractor report and I ended up with this report:

Screen Shot 2020-05-04 at 5 50 59 PM

There was clearly something wrong with my project or the way that I called attractor report.

After reading the README I realized that there was a parameter to tell the library to use a start_ago value. I realized that maybe attractor's default was "too soon" for this particular project: https://github.com/julianrubisch/attractor/blob/master/lib/attractor/calculators/base_calculator.rb#L12

After specifying 10 years as start_ago and running this command:

attractor report --start_ago 10y

I ended up with this report:

Screen Shot 2020-05-04 at 5 52 02 PM

This made me think and I thought about two things:

  • Maybe defaults should be better documented? It could be a section in the README or a comment that ends up here: https://rubydoc.info/gems/attractor/Attractor/BaseReporter#initialize-instance_method
  • Maybe the HTML report should include the start_ago value or the time interval that the report is using?
  • Maybe the attractor help could document defaults and options for the report command? It could be something like attractor report --help that shows available options and defaults.

Before I work on any of this, I thought I'd run it by you and see what you think.

Thanks in advance! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant