Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-review: prompt to update an existing review instead #53

Open
QuLogic opened this issue Aug 19, 2024 · 2 comments
Open

create-review: prompt to update an existing review instead #53

QuLogic opened this issue Aug 19, 2024 · 2 comments

Comments

@QuLogic
Copy link

QuLogic commented Aug 19, 2024

I ran fbrnch create-review for a review I'd already opened (having forgotten about the update-review command); it then printed out:

$ fbrnch create-review -S python-pyogrio.spec 
checking for existing reviews...
Existing review(s):
Review Request: python-pyogrio - Vectorized spatial vector file format I/O using GDAL/OGR (ASSIGNED)
https://bugzilla.redhat.com/show_bug.cgi?id=2294379

Press Enter to continue: 

I didn't realize Enter to continue meant to continue creating a new review and ended up filing a duplicate review.

If the review (as in this case) was opened by me, it would be more convenient if fbrnch switched (automatically or by prompt) to update-review mode instead of creating the duplicate.

@juhp
Copy link
Owner

juhp commented Aug 19, 2024

Makes sense, let me see what I can do

@juhp
Copy link
Owner

juhp commented Aug 19, 2024

Okay, I am making create-review safer in 1.5.1: it will now error unless you pass --force
when existing reviews exist. I started doing the auto-switch to update-review, but I feel
it is a bit complicated and possibly surprising behavior. Though admittedly I don't currently
check who does update-review either hm

Anyway I think this should address your main concern of making it harder to create a duplicate review by mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants