Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding %autorelease support #24

Closed
LyesSaadi opened this issue Oct 2, 2021 · 10 comments
Closed

Adding %autorelease support #24

LyesSaadi opened this issue Oct 2, 2021 · 10 comments

Comments

@LyesSaadi
Copy link
Contributor

Hello again :D!

So, I switched some of my packages over to %autorelease, and fbrnch seems unfortunately not to support that. Indeed, it tries to build for release 1 every time %autorelease is set.

@juhp
Copy link
Owner

juhp commented Oct 3, 2021

Thanks for the report. I am also slowly trying switching some of my packages over...
I will try to look into it, but could you please describe an usage example where you see this occur?

@juhp
Copy link
Owner

juhp commented Oct 3, 2021

Did you mean for fbrnch local or fbrnch build?
For the former at least I think it is expected: though some workaround might be possible.

(BTW I checked in Koji and didn't find any recent builds of yours there exhibiting the issue.)

@LyesSaadi
Copy link
Contributor Author

LyesSaadi commented Oct 3, 2021

It was for badwolf. You didn't see the build because I did an error in 1.2.0-1 (forgot to add a git message (fedpkg ci -c => It put « local build »), and thus releasing a build without changelog), tried to fix it by submitting 1.2.0-2 as an empty commit, which failed as fbrnch refused to submit it, saying 1.2.0-1 was already built, and then had to submit 1.2.0-3 fixing everything (adding changelog entries to explain the update) and then submitted it through fedpkg.

@juhp
Copy link
Owner

juhp commented Oct 4, 2021

Thanks for the explanation, that helps a lot.

So I think I need to improve the nvr check when using %autorelease.

juhp added a commit that referenced this issue Oct 4, 2021
@michel-slm
Copy link

Looking forward to a release that supports this! Coupled with #25 I think I'll have to postpone using fbrnch for my parallel builds

@juhp
Copy link
Owner

juhp commented Dec 29, 2021

Okay thanks for the poke - a new release is long overdue.

Still hoping to get it out this month...

@juhp
Copy link
Owner

juhp commented Feb 21, 2022

fbrnch-1.0.0 is out now btw and coming shortly to Fedora.

@juhp
Copy link
Owner

juhp commented Feb 24, 2022

It is in updates-testing and development releases now.

@juhp
Copy link
Owner

juhp commented Mar 17, 2022

I am adding a few more rpmautospec fixes in the next coming release,
which I hope will be out soonish.

After that I will probably close this, but do please report any more issues you see.

@juhp
Copy link
Owner

juhp commented Apr 30, 2022

I released 1.1

@juhp juhp closed this as completed Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants