Backslashes should probably be escaped

[Feuermurmel]

I tested Grafana's logfmt parser. It doesn't accept e.g foo="\". It simply discards the pair. Tested with a query like this:

{...} | line_format "foo=\"\\\"" | logfmt

But this works:

{...} | line_format "foo=\"\\\\\"" | logfmt

Producing a field containing a single backslash.

[jteppinette]

@Feuermurmel Thank you for this report.

foo=\"\\\\\"

Gotta love that haha

What are your thoughts here. This should be fixed in python-logfmter, I assume?

[jteppinette]

@Feuermurmel Do you know if Grafana uses an open source package for its logfmt parsing?

[Feuermurmel]

What are your thoughts here. This should be fixed in python-logfmter, I assume?

I'd say so. Also because, for example, these two values produce the same output now:

import logfmter

print(logfmter.Logfmter().format_params(dict(foo="\\\"")))
print(logfmter.Logfmter().format_params(dict(foo='\\"')))

foo=\\"
foo=\\"

@Feuermurmel Do you know if Grafana uses an open source package for its logfmt parsing?

I'm not good at reading Go, but if I read the implementation of Process() here correctly, it uses go-logfmt/logfmt to parse Logfmt, specifically the implementation in ScanKeyval().