Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of movements in ShakeAnimation #15

Open
AmorimRob opened this issue Sep 25, 2019 · 2 comments
Open

Number of movements in ShakeAnimation #15

AmorimRob opened this issue Sep 25, 2019 · 2 comments
Assignees

Comments

@AmorimRob
Copy link

Hello Javier!

Before everything, I want to thank you for this amazing lib!

I'm using the lib in my project to animate some entries with Shake Animation when user inserts invalid values.
Talking with the UX professional in my team, she asked me if it is possible to control the number of movements in the shake animation.

Looking at the code, I saw that the class ShakeAnimation have the property Movement but it is private and I can't change it.

What do you think about creating a bindable property for this? With this, the user will be able to control the number of movements in the animation

Thank you!

@jsuarezruiz
Copy link
Owner

Well, it seems like a very good idea!. I will include it as soon as I can. Feel free to send a PR yourself if you want ;).

@jsuarezruiz jsuarezruiz self-assigned this Oct 2, 2019
@AmorimRob
Copy link
Author

Nice! I'm working on this :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants