Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upstreaming: BaseTypeValidator change #43

Open
wmdietl opened this issue Dec 14, 2023 · 0 comments
Open

Upstreaming: BaseTypeValidator change #43

wmdietl opened this issue Dec 14, 2023 · 0 comments

Comments

@wmdietl
Copy link
Collaborator

wmdietl commented Dec 14, 2023

https://github.com/jspecify/checker-framework/blame/2eea6f8242391624def3818289abc44c1ec4ae0b/framework/src/main/java/org/checkerframework/common/basetype/BaseTypeValidator.java#L562

This ignores parts of the checks in visitParameterizedType and notes that the check seems weird.

Steps:

  • investigate whether the EISOP behavior makes sense or needs adjusting,
  • investigate what different behavior the jspecify-reference-checker needs,
  • address by either adjusting upstream in general or adding a new helper method to allow downstream adjustment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@wmdietl