Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Enhancement: Add Escape Key Support to Close Modal and Enhance Cancel Button Functionality #1327

Closed
thepiyush-303 opened this issue Jan 18, 2025 · 2 comments · Fixed by #1328
Closed

✨ Enhancement: Add Escape Key Support to Close Modal and Enhance Cancel Button Functionality #1327

thepiyush-303 opened this issue Jan 18, 2025 · 2 comments · Fixed by #1328
Assignees
@thepiyush-303
Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@thepiyush-303
Copy link
Contributor

thepiyush-303 commented Jan 18, 2025 •
edited
Loading

Is your feature request related to a problem? Please describe

No, it is not related to a problem, it would be better for users who prefer keyboard navigation.

Describe the solution you'd like

Added an event listener in the modal component to listen for the Escape key and trigger the onClose function.

Describe alternatives you've considered

No response

Additional context

Screencast.from.2025-01-19.02-05-36.webm

No response

Are you working on this?

Yes
@thepiyush-303 thepiyush-303 added Status: Triage This is the initial status for an issue that requires triage. ✨ Enhancement Indicates that the issue suggests an improvement or new feature. labels Jan 18, 2025
@thepiyush-303
Copy link
Contributor Author

@DhairyaMajmudar
Please assign this to me.

@DhairyaMajmudar
Copy link
Member

Cool idea @thepiyush-303 pls. go ahead

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 18, 2025
@thepiyush-303 thepiyush-303 mentioned this issue Jan 18, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thepiyush-303 thepiyush-303

Labels
✨ Enhancement Indicates that the issue suggests an improvement or new feature. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
None yet
Milestone
No milestone
2 participants
@DhairyaMajmudar @thepiyush-303