Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Bug: bad spacing in example #1293

Closed
karenetheridge opened this issue Jan 12, 2025 · 2 comments · Fixed by #1297
Closed

🐛 Bug: bad spacing in example #1293

karenetheridge opened this issue Jan 12, 2025 · 2 comments · Fixed by #1297
Assignees
@Karan-Palan
Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.

Comments

@karenetheridge
Copy link
Member

karenetheridge commented Jan 12, 2025 •
edited
Loading

Describe the bug

At https://json-schema.org/learn/getting-started-step-by-step#add-an-external-reference, the example under "To link to the external geographical location schema" has bad spacing in the schema example. Line 2, "warehouseLocation", is vertically misaligned compared to the lines that come after it..

Steps To Reproduce

  1. go to https://json-schema.org/learn/getting-started-step-by-step#add-an-external-reference
  2. scroll down to the third data insert (under bullet 2, "To link to the external geographical location schema")
  3. observe the vertical alignment of lines 2, 3, and 4

Expected Behavior

Since a monospaced font is being used, I expect there to be better vertical alignment.

Screenshots

image

Device Information [optional]

No response

Are you working on this issue?

No

Do you think this work might require an [Architectural Decision Record (ADR)]? (significant or noteworthy)

No
@karenetheridge karenetheridge added 🐛 Bug Indicates that the issue is a bug or defect. Status: Triage This is the initial status for an issue that requires triage. labels Jan 12, 2025
@Karan-Palan
Copy link
Contributor

May I work on this issue?

@DhairyaMajmudar DhairyaMajmudar added Status: In Progress This issue is being worked on, and has someone assigned. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. and removed Status: Triage This is the initial status for an issue that requires triage. labels Jan 12, 2025
@DhairyaMajmudar
Copy link
Member

May I work on this issue?

Sure go ahead, looking forward for your PR.

@Karan-Palan Karan-Palan mentioned this issue Jan 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Karan-Palan Karan-Palan

Labels
🐛 Bug Indicates that the issue is a bug or defect. Status: Accepted It's clear what the subject of the issue is about, and what the resolution should be. Status: In Progress This issue is being worked on, and has someone assigned.
Projects
Website Contributor Board
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: correct vertical alignment issue in schema example Karan-Palan/website
3 participants
@karenetheridge @DhairyaMajmudar @Karan-Palan