Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict max width of combo box list to the input width #4361

Open
1 task done
origami-z opened this issue Oct 30, 2024 · 0 comments
Open
1 task done

Restrict max width of combo box list to the input width #4361

origami-z opened this issue Oct 30, 2024 · 0 comments
Labels
community For issues that have been raised by folks outside the core Salt team component: combo box component: dropdown status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request

Comments

@origami-z
Copy link
Contributor

origami-z commented Oct 30, 2024 •
edited
Loading

Description

When long list item is used, list dropdown becomes wider than the input.

salt-ds/packages/core/src/combo-box/ComboBox.tsx

Line 190 in 7d0d998

minWidth: `${rects.reference.width}px`,

Expected behavior

Have a way to restrict list width, and achieve similar result from UITK: Show ellipses + tooltip.

Alternatives and examples

Could be part of #3599

Context

SO 92891

Are you a JPMorgan Chase & Co. employee?

  • I am an employee of JPMorgan Chase & Co.
@origami-z origami-z added type: enhancement 💡 New feature or request status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. community For issues that have been raised by folks outside the core Salt team component: combo box component: dropdown labels Oct 30, 2024
@origami-z origami-z changed the title Restrict max width of combo box list to the same of input Restrict max width of combo box list to the input width Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
community For issues that have been raised by folks outside the core Salt team component: combo box component: dropdown status: awaiting triage Automatically added to new issues. Should be removed once they have been triaged. type: enhancement 💡 New feature or request
Projects
Salt - Components, Patterns and Theming
Status: Green
Milestone
No milestone
Development

No branches or pull requests
1 participant
@origami-z