Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluate whether we should/could replace nbval with nbclient #189

Open
ceball opened this issue Jun 16, 2020 · 0 comments
Open

Evaluate whether we should/could replace nbval with nbclient #189

ceball opened this issue Jun 16, 2020 · 0 comments
Labels
part: cell tests Relating to cell testing component tag: question Questions about use, potential features, or improvements

Comments

@ceball
Copy link
Collaborator

ceball commented Jun 16, 2020

I recently noticed that notebook execution has been extracted from nbconvert into a standalone library, nbclient (https://github.com/jupyter/nbclient/). Should evaluate whether:

  • We can replace import/usage of nbval with nbclient
  • We can replace internal partial copy/paste of nbval with nbclient
  • (nbval itself could use parts of nbclient?)

The motivation being that nbval has more customized kernel communication requirements than nbcelltests (nbval is inspecting outputs etc), which means:

  • nbval doesn't currently provide a convenient method we can use to communicate with the kernel that does not also involve dealing with outputs, so we have a copy/paste/modify of an nbval method in celltests
  • nbval might introduce issues (e.g. Certain cell failures are not detected #190)

Is nbclient simpler/safer/more likely to stay up to date? Does it provide an interface we can use? Etc

@ceball ceball added part: cell tests Relating to cell testing component question labels Jun 16, 2020
@timkpaine timkpaine added tag: question Questions about use, potential features, or improvements and removed question labels Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
part: cell tests Relating to cell testing component tag: question Questions about use, potential features, or improvements
Projects
None yet
Development

No branches or pull requests

2 participants