Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Try default editors in kit import if $EDITOR is not defined #713

Closed
amisevsk opened this issue Jan 22, 2025 · 1 comment · Fixed by #721
Closed

Try default editors in kit import if $EDITOR is not defined #713

amisevsk opened this issue Jan 22, 2025 · 1 comment · Fixed by #721
Assignees
@amisevsk
Labels
enhancement New feature or request

Comments

@amisevsk
Copy link
Contributor

Describe the problem you're trying to solve
Currently, kit will look to the EDITOR environment variable to determine what editor should be used to update the Kitfile before packing. However, not all systems have this environment variable set by default.

Describe the solution you'd like
We should try a default editor (e.g. nano on Linux/MacOS) if the environment variable is unset. If the default editor is not installed, we should print the current message

Additional context
Originally reported in #708
@amisevsk amisevsk added the enhancement New feature or request label Jan 22, 2025
@amisevsk amisevsk self-assigned this Jan 22, 2025
@amisevsk amisevsk mentioned this issue Jan 22, 2025
Open
@bmicklea
Copy link
Contributor

In the meantime I have issued a PR to update the docs to at least clarify that we need a default editor defined in the $EDITOR env var. #719

@amisevsk amisevsk mentioned this issue Jan 23, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@amisevsk amisevsk

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use 'nano' as the default editor in import if $EDITOR is unset amisevsk/kitops
2 participants
@bmicklea @amisevsk