Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR checklist checker makes too many comments and can be bypassed #119

Open
josh-wong opened this issue Oct 27, 2024 · 0 comments
Open

PR checklist checker makes too many comments and can be bypassed #119

josh-wong opened this issue Oct 27, 2024 · 0 comments
Assignees
Labels
improvement Improvement to an existing feature

Comments

@josh-wong
Copy link
Owner

josh-wong commented Oct 27, 2024

The following should be done to improve the PR checklist checker workflow:

  • To avoid a long list of failed and/or successful checks, the workflow should update its existing comment in a PR. (Ref: #118)
  • If the workflow fails, the PR should not be able to be merged.
  • Don't check for checklists if the PR description doesn't include a checklist. (Ref: #120)
@josh-wong josh-wong added the improvement Improvement to an existing feature label Oct 27, 2024
@josh-wong josh-wong self-assigned this Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant