Why did it not run correctly?

[zero-24]

Some issues have to be manually created as the bot does not run correct to catch them. This needs to be debugged and understood and fixed.

example
joomlagerman/joomla#2309 (comment)

[heelc29]

@zero-24 These are some PRs (in 2022) for which the bot haven't created issues.

Id	Title	Closed
37527	Fix mismatch in column and sort table	2022-04-12T01:24:10Z
37286	[4.1] Missing error strings in installation	2022-04-02T02:12:44Z
37115	[4.1] Remove invalid tooltip option in media field	2022-04-02T00:00:03Z
37393	[4.1] Add text COM_WORKFLOW_STAGE_FORM_NEW to com_workflow.ini	2022-03-28T23:21:42Z
36875	[4.1] com_scheduler checked out tasks	2022-03-14T04:46:00Z
37224	[4.1] scheduler sorting	2022-03-09T05:05:50Z
35323	[4] Remove all references to LDAP ignore_reqcert_tls	2022-03-03T03:15:16Z
37129	[4.1] Codemirror Full Screen	2022-03-03T02:18:40Z
36865	[J4.1] Better "Your Modules" Article	2022-02-22T00:51:49Z
37014	[4.1] add rel="noopener noreferrer" for target="blank" links	2022-02-22T00:39:30Z
36591	[4.1] User defined Hide Table Columns	2022-02-01T20:23:46Z
36515	[4.1] Simplify Requirements for Task Routine XMLs	2022-01-10T01:20:13Z
36328	[4.1] TinyMCE option to initially paste text without formatting	2022-01-10T01:14:52Z
36492	[4.0] Joomla Update Silent fails	2022-01-08T23:17:41Z

Issues were created here:

Id	Title	Closed
37535	[4.1] adjustments in lang files	2022-04-12T13:46:34Z
37464	[4.1] webauthn table accessibility	2022-04-03T19:13:29Z
37453	[4.2] Deprecating WinCache for Joomla 5.0	2022-04-02T11:57:16Z
37416	[3.10] Disable auth binding code introduced with 3.10.7	2022-03-30T12:00:34Z
37415	[4.1] Disable auth binding code introduced with 4.1.1	2022-03-30T11:56:38Z
37406	[4.1] Language string	2022-03-29T19:23:54Z
37404	[4.2] Upmerge 2022-03-29	2022-03-29T16:52:30Z
37345	Translation Update	2022-03-30T20:14:18Z
37334	language-update-de	2022-03-21T12:17:11Z
37323	[4.1] alpha sorting in all 3 joomla.ini	2022-03-20T08:17:17Z
37316	Translation Update	2022-03-19T20:56:57Z
37311	Upmerge 3.10 to 4.1.1	2022-03-18T18:16:45Z
37307	[4.1] Admin User accessibility settings	2022-03-18T09:29:34Z
37284	Translation Update	2022-03-16T10:00:49Z
37238	[4.1] Remove Bootstrap tooltip	2022-03-11T19:39:08Z
37203	[4.1] WebAuthn hints	2022-03-12T10:38:27Z
37196	[4.1] jooa11y plugin options	2022-03-07T10:34:34Z
37181	[3.10] Privacy Consent wording I agree and No	2022-03-17T16:50:58Z
37133	[4.1] Private Messages Emails	2022-03-11T08:00:31Z

When it didn't work to create the Issues, the merge-time was around midnight (UTC).

[zero-24]

When it didn't work to create the Issues, the merge-time was around midnight (UTC).

hmm that would make sense as the check is "show me the merged PRs" and the Jobs runs only once getting all closed things for the latest

jgerman-bot/src/GithubApiHelper.php

Lines 191 to 200 in 133d3c9

	private function getClosedTranslationIssuesList($since)
	{
	// List all closed issues with the watchlabel
	$state = 'closed';
	$labels = urlencode($this->getOption('source.watchlabel'));
	return $this->github->issues->getListByRepository(
	$this->getOption('source.owner'), $this->getOption('source.repo'), NULL, $state, NULL, NULL, $labels, NULL, NULL, $since
	);
	}

@tecpromotion can you please confirm the time where the bot is expected to be triggered and what timezone the server has where it runs on? Maybe we need to change the time to trigger this job so we match the correct UTC time?

[tecpromotion]

@zero-24 fyi

[zero-24]

Ok can we please set the execution time to 4:15 that should make sure we are past the 24 on UTC

[zero-24]

@wojsmol please check the execution time on your end too.

[tecpromotion]

cron time fixed

[zero-24]

top lets see how it goes now.

[wojsmol]

@zero-24 Our bot runs on 0:30 in Europe/Warsaw time zone enforced also for cron jobs, so this should be ok.

[zero-24]

When it is a timezone issue and the GitHub API would use UTC as a base to generate the list for "yesterday" you should be affected by this too.

UTC: 23:40 German time: 01:40

So when our bot would run on 01:40 we would only get every PR that has been merged up until 23:40 but nothing after.

So I asked Stefan to do it at 04:15 german time so we are 100% sure UTC is past 24:00 and even when the list of "yesterday" is calculated of the UTC timestamp.

[wojsmol]

@zero-24 I moved execution of ouer bot to 4:30 in Europe/Warsaw time zone.

[heelc29]

Not worked

Id	Title	Closed
37683	Fix options in mailtemplate form	2022-04-30T02:45:39Z
37666	[4.1] com_content: hardcoded language string	2022-04-30T02:49:20Z
37641	[4.1] Discover extension strings	2022-04-26T00:01:41Z

worked

Id	Title	Closed
37657	[4.x] Batch Users move	2022-04-28T00:18:23Z

[zero-24]

hmm thanks for checking will add it to my list to deeper check whats happend there maybe i did something wrong in the implementation?

[wojsmol]

Regarding 37666 label was re-added after our bots run for this day.

[heelc29]

Regarding 37666 label was re-added after our bots run for this day.

But only after 4 seconds ... at this time the bot hasn't run

[wojsmol]

The add label event was on 04:49 CEST and our bots are tuning on:

• German 4.15 CEST
• Polish 4:30 CEST

Bots are looking for merged PR's from yesterday withy Language Change label

[heelc29]

Bots are looking for merged PR's from yesterday withy Language Change label

At this time the PR wasn't merged 🤔

• Bot run 2022-04-30 4:15/30 CEST looks for PRs merged on 2022-04-29
• PR 37666 is merged on 2022-04-30 4:49 CEST
• Bot run 2022-05-01 4:15/30 CEST looks for PRs merged on 2022-04-30 (and should find 37666)
• Bot run 2022-05-02 4:15/30 CEST looks for PRs merged on 2022-05-01 (eg 37704, 37689)

PS: your link is to 37666 and you write about 37641 😉

[wojsmol]

PS: your link is to 37666 and you write about 37641 😉

I updated PR number in my comment.