Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Can I unite to_* and stabilize_*? #46

Closed
jonthegeek opened this issue Aug 13, 2023 · 1 comment
Closed

Spike: Can I unite to_* and stabilize_*? #46

jonthegeek opened this issue Aug 13, 2023 · 1 comment
Milestone

Comments

@jonthegeek
Copy link
Owner

If I can make stabilize_* fast for defaults, I don't need multiple functions. In any case, I think I want everything to be named stabilize_. Maybe if I need more args I use stabilize__more?

@jonthegeek jonthegeek added this to the v0.1 milestone Aug 16, 2023
@jonthegeek
Copy link
Owner Author

The speed hit appears to be negligible, and it's actually considerably faster to check NULLs, which might prove useful. Fastest is with a single shared function that does NOT use S3. Might be possible to make it even faster by moving the S3 stuff inside the length check; putting the length check up front appears to be on of our biggest gains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

1 participant