Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoded options #106

Closed
arogachev opened this issue Sep 19, 2016 · 2 comments
Closed

Avoid hardcoded options #106

arogachev opened this issue Sep 19, 2016 · 2 comments

Comments

@arogachev
Copy link

arogachev commented Sep 19, 2016 •
edited
Loading

Some options, such as minSize are now hardcoded (minSize is set to [5, 5] for example). It's better to avoid that and add possibility to set it via settings.
@arogachev arogachev mentioned this issue Sep 19, 2016
Open
@anrie
Copy link
Member

anrie commented Sep 25, 2016

@arogachev I agree. That would make sense as setting. Feel free to send a PR!

@anrie
Copy link
Member

anrie commented Sep 25, 2016

Okay, I think the issue is covered sufficiently by #105 so I am closing this.

@anrie anrie closed this as completed Sep 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anrie @arogachev