Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

renderSync => render #58

Open
chriseppstein opened this issue Mar 31, 2015 · 5 comments
Open

renderSync => render #58

chriseppstein opened this issue Mar 31, 2015 · 5 comments

Comments

@chriseppstein
Copy link

As I understand it, broccoli prefers synchronous file i/o for performance reasons. But I don't think that broccoli should use node-sass's renderSync method. Instead, I think it should use the async render method. We need to run several hundred sass compiles per build (number of sass files times the number of locale's we support) and this should help with throughput.

@stefanpenner tells me this is very doable, but I have forgot the specifics.

If there's no objection, I can work on a patch with a few code pointers.

@joliss
Copy link
Owner

joliss commented Apr 1, 2015

Yeah that's fine and definitely possible - just return a promise from updateCache. A patch would be awesome. Can you post before/after timings as well?

As for style, you might know this already but RSVP.denodeify often helps with making callback-based code look pretty. :)

@chriseppstein
Copy link
Author

Can you post before/after timings as well?

timings of what? The tests?

@joliss
Copy link
Owner

joliss commented Apr 2, 2015

No such "tests" ;-)

I mean timing of some non-trivial app that you have, that you're trying to speed up. (The sole motivation for this is performance, correct?)

@stefanpenner
Copy link

No the motivation is to enable sass plugins and ecosystem to have async

@joliss
Copy link
Owner

joliss commented Apr 2, 2015

Oh, OK, that sounds great. Never mind then, no timings needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants