-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
renderSync => render #58
Comments
Yeah that's fine and definitely possible - just return a promise from As for style, you might know this already but |
timings of what? The tests? |
No such "tests" ;-) I mean timing of some non-trivial app that you have, that you're trying to speed up. (The sole motivation for this is performance, correct?) |
No the motivation is to enable sass plugins and ecosystem to have async |
Oh, OK, that sounds great. Never mind then, no timings needed. |
As I understand it, broccoli prefers synchronous file i/o for performance reasons. But I don't think that broccoli should use node-sass's renderSync method. Instead, I think it should use the async render method. We need to run several hundred sass compiles per build (number of sass files times the number of locale's we support) and this should help with throughput.
@stefanpenner tells me this is very doable, but I have forgot the specifics.
If there's no objection, I can work on a patch with a few code pointers.
The text was updated successfully, but these errors were encountered: