Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom Path implementation in favor of PEP428 #183

Open
codingjoe opened this issue May 15, 2018 · 1 comment
Open

Remove custom Path implementation in favor of PEP428 #183

codingjoe opened this issue May 15, 2018 · 1 comment
Labels
enhancement New feature or request

Comments

@codingjoe
Copy link

Is there any good reason why this library implements it's own path implementation even tho there is a builtin in Python?
https://docs.python.org/3/library/pathlib.html#module-pathlib
https://www.python.org/dev/peps/pep-0428/

My suggestion would be to replace it, to reduce complexity and avoid people confusing them.

@codingjoe
Copy link
Author

I would suggest to deprecate the current path implementation with a warning and update the documentation to use the builtin one.

Oh and I am aware the PEP428 is not implemented in Python 2, but hey it's 2018. Even Django dropped Python 2 support. Do you really still want to support it? If you want to use and old Python and Django version, you are probably good using an old version of this package too.

tkdchen pushed a commit to tkdchen/django-environ that referenced this issue Oct 6, 2019
This will generate a better coverage.xml file, which makes it easier for
codecov hopefully.

Old:

    <sources>
            <source>…/Vcs/django-configurations/configurations</source>
            <source>…/Vcs/django-configurations/tests</source>
    </sources>
    <packages>
            <package branch-rate="0.7178" complexity="0" line-rate="0.8902" name=".">

New:
    <sources>
            <source>…/Vcs/django-configurations</source>
    </sources>
    <packages>
            <package branch-rate="0.712" complexity="0" line-rate="0.8126" name="configurations">

Fixes jazzband/django-configurations@d364802#commitcomment-24826518.
@sergeyklay sergeyklay added hacktoberfest enhancement New feature or request and removed hacktoberfest labels Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants