Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images Fail to Download to External Storage #955

Open
gozes opened this issue Nov 14, 2024 · 2 comments
Open

Images Fail to Download to External Storage #955

gozes opened this issue Nov 14, 2024 · 2 comments
Labels
bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp

Comments

@gozes
Copy link

gozes commented Nov 14, 2024

finamp-logs.txt

So I joined the beta today and trying to download some of my library to the SD card on my DAP. However as you can see from the logs it looks like I'm getting a lot of failed image downloads. Looking at the SD card it looks like the songs downloaded fine but I haven't tried all of them to be sure. It's hard for me to tell if the missing images would cause any issues. I usually add the cover art to every song when I tag them so it's unclear to me what images it's trying to download

@gozes
Copy link
Author

gozes commented Nov 14, 2024

So tapping around it seems that the images that fail to download are the ones that will be used in the player and as the album cover as songs seem to play fine in offline mode I just have a bunch of blurry colors that resemble the cover art instead of the actual cover art. The same is true for the artist tab in offline mode. I find it a bit strange it it's trying to pull down the album cover when I embedded the cover art on each song when I tag them so I would think I finamp would just look to see if track one has an image embedded then use that instead of trying to download it. Reducing the number of runners from 10 to 5 didn't really do much aside from making the process slower

@Chaphasilor
Copy link
Collaborator

Yes, that is a known issue that I also mentioned in my comment #842 (comment)

I've managed to pinpoint this to images failing to download for any tracks where no other track from that album has already been downloaded. It seems to be a permission issue, but I'm not yet totally sure why it happens.

Finamp doesn't look at the tags of files at all, all information is fetched from the server. That's by design, and in some cases like when transcoding is the only way to get the data.

@Chaphasilor Chaphasilor changed the title [Beta] lots of failed requests image when downloading from server Images Fail to Download to External Storage Nov 15, 2024
@Chaphasilor Chaphasilor added bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp labels Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working downloading Issues related to the download system redesign-beta Issues related to the beta/redsigned version of Finamp
Projects
None yet
Development

No branches or pull requests

2 participants