Updated for Django 3.0 and added ability for blank fields #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
March 12, 2020 10:26
Adrian-at-CrimsonAzure
force-pushed
the
master
branch
from
e8f955a to
8845f6f
Compare
Adrian-at-CrimsonAzure
force-pushed
the
master
branch
from
19b0105 to
25f49e5
Compare
Adrian-at-CrimsonAzure
force-pushed
the
master
branch
from
25f49e5 to
8a4fc12
Compare
|
No idea why the Django 3.0 test is failing. I don't want to invest more time into it and I am not familiar enough with the codebase. It's working fine in my Django 3.0 app running on Python 3.6 If someone else wants to take a look at it, be my guest. |
|
Not sure how I missed this PR. I just fixed a bunch of bugs after discovering another user was still using this on modern versions of Django. I'm going to look at the other stuff you did with the blank values. At this point I've just dropped support for Python 2, although I'm sure there's more cleanup to be done if I take a closer look. I just fixed quick, obvious stuff while I was in dealing with the main problem I set out to fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
It Will now only import if Django version is older than 3.
I also added the ability to leave the fields blank since I found it annoying that you couldn't do this.
I have not tested this with Django 2.x as I have moved all of my projects over to 3.x but I don't see any reason why this wouldn't work.