From cf14a33fb4281e1f6ad512b778bc0f1c869ce8f1 Mon Sep 17 00:00:00 2001 From: Jaya Allamsetty Date: Thu, 12 Sep 2024 15:53:25 -0400 Subject: [PATCH] fix(quality) Do not force desktop codecs on mobile. If the mobileCodecPreferenceOrder setting is missing, use the default order for mobile. Fixes an issue where mobile endpoints encodes using AV1 when mobile settings are missing. --- JitsiConference.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/JitsiConference.js b/JitsiConference.js index 435d3c000e..46ac2ad1da 100644 --- a/JitsiConference.js +++ b/JitsiConference.js @@ -444,8 +444,8 @@ JitsiConference.prototype._init = function(options = {}) { enableAdaptiveMode: config.videoQuality?.enableAdaptiveMode, lastNRampupTime: config.testing?.lastNRampupTime ?? 60000, jvb: { - preferenceOrder: browser.isMobileDevice() && config.videoQuality?.mobileCodecPreferenceOrder - ? config.videoQuality.mobileCodecPreferenceOrder + preferenceOrder: browser.isMobileDevice() + ? config.videoQuality?.mobileCodecPreferenceOrder : config.videoQuality?.codecPreferenceOrder, disabledCodec: _getCodecMimeType(config.videoQuality?.disabledCodec), preferredCodec: _getCodecMimeType(config.videoQuality?.preferredCodec), @@ -454,8 +454,8 @@ JitsiConference.prototype._init = function(options = {}) { : _getCodecMimeType(config.videoQuality?.screenshareCodec) }, p2p: { - preferenceOrder: browser.isMobileDevice() && config.p2p?.mobileCodecPreferenceOrder - ? config.p2p.mobileCodecPreferenceOrder + preferenceOrder: browser.isMobileDevice() + ? config.p2p?.mobileCodecPreferenceOrder : config.p2p?.codecPreferenceOrder, disabledCodec: _getCodecMimeType(config.p2p?.disabledCodec), preferredCodec: _getCodecMimeType(config.p2p?.preferredCodec),