Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE]: Could you add PiP listener? Or method which forces PiP mode? #26

Open
stryder123451 opened this issue Nov 7, 2023 · 6 comments

Comments

@stryder123451
Copy link

Hi, could you please, add Picture in Picture mode listener, or method which forces Picture in Picture mode?

@gabiborlea
Copy link
Contributor

There is a little issue with the android part when integrating this, but I'll give it a look and see what I can do.

@stryder123451
Copy link
Author

There is a little issue with the android part when integrating this, but I'll give it a look and see what I can do.

i need this feature only in iOS, or could you please , say , where i can listen , PiP changed? I saw your code and try to edit this.
I need hide keyboard when jitsi goes to full screen from PiP mode, i tried like this:

    override func viewWillTransition(to size: CGSize,
                                     with coordinator: UIViewControllerTransitionCoordinator) {
        super.viewWillTransition(to: size, with: coordinator)

        let rect = CGRect(origin: CGPoint.zero, size: size)
        pipViewCoordinator?.resetBounds(bounds: rect)
        view.endEditing(true) // Here 
    }

@stryder123451
Copy link
Author

@gabiborlea ok, i did it, but it will be cool if you could add PiP listener, i saw it in other packages, but it was only for android

@stryder123451
Copy link
Author

stryder123451 commented Nov 10, 2023

@gabiborlea and also , think jitsi must close keyboard when goes into PiP mode, cause it causes lags like this:
image

@gabiborlea
Copy link
Contributor

How to reproduce this issue?

@stryder123451
Copy link
Author

How to reproduce this issue?

open keyboard on iOS when jitsi in pip mode, and with opened keyboard set jitsi in fullscreen, i already fix that and planning to make pull request soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants