Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jibri: custom-jibri.conf not included correctly #2005

Open
peb-adr opened this issue Jan 22, 2025 · 2 comments
Open

jibri: custom-jibri.conf not included correctly #2005

peb-adr opened this issue Jan 22, 2025 · 2 comments

Comments

@peb-adr
Copy link

peb-adr commented Jan 22, 2025

From what I can tell jibri/rootfs/defaults/jibri.conf (or the resulting /etc/jitsi/jibri/jibri.conf in the running container) end with include "custom-jibri.conf".

It appears to me one would have to place the file /etc/jitsi/jibri/custom-jibri.conf in the container which isn't possible without modifying the image.

I would expect to be able to place my custom-jibri.conf in the config directory which is mounted to /config in the container, as is done similarly for (at least) the web component.
If this is correct the include directive should change to include "/config/custom-jibri.conf".

@peb-adr
Copy link
Author

peb-adr commented Jan 22, 2025

Ok, I have tested my proposed change and verified it works as expected.

Maybe for more context, my custom-jibri.conf looks like this:

jibri {
    streaming {
        // A list of regex patterns for allowed RTMP URLs.  The RTMP URL used
        // when starting a stream must match at least one of the patterns in
        // this list.
        rtmp-allow-list = [
            ".itspersonal.*"
        ]
    }
}

Indeed the whitelist was checked after I included it from /config (and wasn't before).

@peb-adr
Copy link
Author

peb-adr commented Jan 22, 2025

#2006 would fix this.

If I missed the actual way I was supposed to use the custom-jibri.conf I would appreciate a hint on how.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant