Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work with proxy #98

Open
LMS007 opened this issue Sep 6, 2017 · 0 comments
Open

Does not work with proxy #98

LMS007 opened this issue Sep 6, 2017 · 0 comments

Comments

@LMS007
Copy link

LMS007 commented Sep 6, 2017

Please allow some pass through S3 configuration options so this can work with a proxy. Its necessary to have these options exposed in the s3.js file otherwise this won't work with a proxy server.

sslEnabled
httpOptions.proxy
httpOptions.timeout

Such as...

try {
  // create an AWS S3 client with the config data
  client = new s3({
    accessKeyId: env.AWS_ACCESS_KEY_ID,
    secretAccessKey: env.AWS_SECRET_ACCESS_KEY,
    region: env.AWS_REGION,
    sslEnabled: env.S3_SSL_ENABLED,       /* new env option */
    httpOptions: {
      proxy: env.S3_PROXY,                /* new env option */
      timeout : env.S3_TIMEOUT,           /* new env option */
    },
  });
  bucket = env.S3_BUCKET;
} catch(e) {

}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant