Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add additional logging when using EXTERNAL_SOURCE_* #79

Open
mariusa opened this issue Nov 15, 2015 · 1 comment
Open

Please add additional logging when using EXTERNAL_SOURCE_* #79

mariusa opened this issue Nov 15, 2015 · 1 comment

Comments

@mariusa
Copy link

mariusa commented Nov 15, 2015

Hello,

I've added an EXTERNAL_SOURCE_* which works only a few times, but fails on reload (original source responds with 404, although accessing it from browser works).
Trying to figure out what's happening.

The logging only mentions now
GET /ewikipedia-h10/en/7/70/Example.png?v=123 200

Would you please add another GET line for the original source, e.g.
GET original https://upload.wikimedia.org/wikipedia/en/7/70/Example.png?v=123
and errors?

Thanks

@teohhanhui
Copy link

Actually the error is already being logged.

See:

if (response.statusCode !== 200) {
_this.image.error = new Error('Error ' + response.statusCode + ':');
}

and
if(_this.image.isError()) {
_this.image.error.message += Buffer.concat(bufs);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants